On Sun, 30 Mar 2025, Matthew Wilcox wrote:
We deliberately don't sleep when the folio is only a single page. So this needs to be: might_sleep_if(folio_test_large(folio));
Along with willy's suggestion: Acked-by: Davidlohr Bueso <dave@xxxxxxxxxxxx> ... and the same rules apply for copy_folio(): fs/aio.c: atomic context but no large folio: safe fs/fuse/file.c: no large folio: safe fs/nilfs2/page.c: blocking safe, has large folio: safe mm/migrate_device.c: no large folio: safe mm/shmem.c: blocking safe, has large folio: safe shmem_replace_folio() could use a might_sleep() I guess. Thanks, Davidlohr