On Mon, Mar 24, 2025 at 03:53:23PM -0700, Joe Damato wrote: > On Mon, Mar 24, 2025 at 02:15:26PM -0700, Jakub Kicinski wrote: > > On Sat, 22 Mar 2025 20:35:45 +0000 Joe Damato wrote: > > > Eliminate the #ifdef CONFIG_NET from fs/splice.c and move the > > > splice_to_socket helper to net/socket.c, where the other splice socket > > > helpers live (like sock_splice_read and sock_splice_eof). > > > > > > Signed-off-by: Joe Damato <jdamato@xxxxxxxxxx> > > > > Matter of preference, to some extent, but FWIW: > > > > Acked-by: Jakub Kicinski <kuba@xxxxxxxxxx> > > Thanks for the ACK. > > It looks like Jens thinks maybe the code should stay where it is and > given that it might be more "splice related" than networking, it may Uhm, it should stay in fs/ especially since it's closely tied to pipe_lock().
