On Mon, Mar 24, 2025 at 04:14:06PM -0600, Jens Axboe wrote: > On 3/22/25 2:35 PM, Joe Damato wrote: > > Greetings: > > > > While reading through the splice and socket code I noticed that some > > splice helpers (like sock_splice_read and sock_splice_eof) live in > > net/socket.c, but splice_to_socket does not. > > > > I am not sure if there is a reason for this, but it seems like moving > > this code provides some advantages: > > - Eliminates the #ifdef CONFIG_NET from fs/splice.c > > - Keeps the socket related splice helpers together in net/socket.c > > where it seems (IMHO) more logical for them to live > > Not sure I think this is a good idea. Always nice to get rid of some > ifdefs, but the code really should be where it's mostly related to, and > the socket splice helpers have very little to do with the networking > code, it's mostly just pure splice code. OK, if you prefer not to merge this I totally understand. I am not aware of the history behind it all and I can definitely see the argument for leaving it as is because the code might be more "splice-related" than networking. In which case: sorry for the noise.
