On 03/23, Christian Brauner wrote: > > On Sun, Mar 23, 2025 at 06:45:18PM +0100, Oleg Nesterov wrote: > > > > I think it is a bad idea to do the things like > > > > #ifndef __NR_clone3 > > #define __NR_clone3 -1 > > #endif > > > > because this can hide a problem. My working laptop runs Fedora-23 which > > doesn't have __NR_clone3/etc in /usr/include/. So "make" happily succeeds, > > but everything fails and it is not clear why. > > Yeah, I agree. You want to send your small patch as a quick fix? OK, will do. FYI, I have another fixlet, exit_info->exit_code = tsk->exit_code; in pidfs_exit() no longer looks correct with the recent changes. In fact this was probably wrong after we decided to move pidfs_exit() to release_task(), but I didn't notice this when I reviewed the last version of "pidfs: record exit code and cgroupid at exit". But I need to write the changelog which should explain the uglyness we already have, and the reason for the change. Perhaps we don't really care, but I think this should be discussed at least. Oleg.
