Hi Matthew... I've run version 2 of your "orangefs folio" patch through xfstests with no regressions... -Mike On Wed, Mar 5, 2025 at 3:47 PM Matthew Wilcox (Oracle) <willy@xxxxxxxxxxxxx> wrote: > > 'len' is used to store the result of i_size_read(), so making 'len' > a size_t results in truncation to 4GiB on 32-bit systems. > > Signed-off-by: Matthew Wilcox (Oracle) <willy@xxxxxxxxxxxxx> > Tested-by: Mike Marshall <hubcap@xxxxxxxxxxxx> > --- > fs/orangefs/inode.c | 7 +++---- > 1 file changed, 3 insertions(+), 4 deletions(-) > > diff --git a/fs/orangefs/inode.c b/fs/orangefs/inode.c > index aae6d2b8767d..63d7c1ca0dfd 100644 > --- a/fs/orangefs/inode.c > +++ b/fs/orangefs/inode.c > @@ -23,9 +23,9 @@ static int orangefs_writepage_locked(struct page *page, > struct orangefs_write_range *wr = NULL; > struct iov_iter iter; > struct bio_vec bv; > - size_t len, wlen; > + size_t wlen; > ssize_t ret; > - loff_t off; > + loff_t len, off; > > set_page_writeback(page); > > @@ -91,8 +91,7 @@ static int orangefs_writepages_work(struct orangefs_writepages *ow, > struct orangefs_write_range *wrp, wr; > struct iov_iter iter; > ssize_t ret; > - size_t len; > - loff_t off; > + loff_t len, off; > int i; > > len = i_size_read(inode); > -- > 2.47.2 >
