Willy, On Thu, Feb 20, 2025 at 2:51 PM Matthew Wilcox <willy@xxxxxxxxxxxxx> wrote: > On Mon, Feb 10, 2025 at 01:34:38PM +0000, Matthew Wilcox (Oracle) wrote: > > I think this may be the last batch of patches to gfs2 for folio > > conversions. The only remaining references to struct page that I see are > > for filesystem metadata that isn't stored in the page cache, so those are > > fine to continue using struct page. The only mild improvement would be if > > we could have different bio completion handlers for gfs2_end_log_write() > > when it's using mempool pages vs folio pages, but that may not even be > > feasible and I like the current solution well enough. > > > > This all seems fairly straightforward to me, but as usual only > > compile-tested. I don't anticipate the change to buffer_head.h to have > > any conflicts; removing the last user of page_buffers() is not on the > > cards for the next merge window. > > ping thanks a lot for these patches; I'm adding them to for-next. Andreas