On Mon, Feb 24, 2025 at 02:14:44PM +0000, Al Viro wrote: > On Mon, Feb 24, 2025 at 11:35:47AM +0100, Christian Brauner wrote: > > > I think it would be worthwhile to mark dentries of such filesystems as > > always unhashed and then add an assert into fs/dcache.c whenever such a > > dentry should suddenly become hashed. > > > > That would not just make it very easy to see for the reviewer that the > > dentries of this filesystem are always unhashed it would also make it > > possible to spot bugs. > > Not sure that's useful, really... Details are tied into the tree-in-dcache > rework, and I'll need to finish resurrecting that; should post in a week > or so. > > For this series, see viro/vfs.git#work.dcache - it's a WIP at the moment, > and it's going to get reordered (if nothing else, d_alloc_parallel() > side needs an audit of tree-walkers to prove that it won't get confused > by seeing DCACHE_PAR_LOOKUP on the stuff that hasn't yet reached in-lookup > hash chains, and that might add prereqs that would need to go early in > queue), but that at least fleshes out what I described upthread. > > I'll post individual patches for review in a few hours. Went through them all. Everything looks good! Thanks! Christian
