This patch series removes some unnecessary sourcing of common/rc and decouples the call to init_rc() from the sourcing of common/rc. This is proposed in [1] and [2]. It also removes direct usage of exit command with a _exit wrapper. The individual patches have the details. [v2] --> [v3] 1. Added R.Bs from Dave[3] and Ritesh in all the patches of [v2] 2. Replaced status=1;exit with "_exit 1" in some of the functions I missed in [v2] 3. Added some comments in the check script(suggested by Ritesh) 4. Added a new patch (patch 2) that removes redundant sourcing of common/config in generic/367 5. As of now, I didn't change the definition of _exit() function. [1] https://lore.kernel.org/all/20250206155251.GA21787@frogsfrogsfrogs/ [2] https://lore.kernel.org/all/20250210142322.tptpphdntglsz4eq@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx/ [3] https://lore.kernel.org/all/Z-xcne3f5Klvuxcq@xxxxxxxxxxxxxxxxxxx/ [v1] https://lore.kernel.org/all/cover.1741248214.git.nirjhar.roy.lists@xxxxxxxxx/ [v2] https://lore.kernel.org/all/cover.1743487913.git.nirjhar.roy.lists@xxxxxxxxx/ Nirjhar Roy (IBM) (6): generic/749: Remove redundant sourcing of common/rc generic/367: Remove redundant sourcing if common/config check: Remove redundant _test_mount in check check,common{rc,preamble}: Decouple init_rc() call from sourcing common/rc common/config: Introduce _exit wrapper around exit command common: exit --> _exit check | 10 ++--- common/btrfs | 6 +-- common/ceph | 2 +- common/config | 15 +++++-- common/dump | 11 +++-- common/ext4 | 2 +- common/populate | 2 +- common/preamble | 3 +- common/punch | 13 +++--- common/rc | 107 ++++++++++++++++++++++------------------------ common/repair | 4 +- common/xfs | 8 ++-- tests/generic/367 | 1 - tests/generic/749 | 1 - 14 files changed, 91 insertions(+), 94 deletions(-) -- 2.34.1
