On 4/2/25 03:07, Dave Chinner wrote:
On Tue, Apr 01, 2025 at 06:43:55AM +0000, Nirjhar Roy (IBM) wrote:This patch series removes some unnecessary sourcing of common/rc and decouples the call to init_rc() from the sourcing of common/rc. This is proposed in [1] and [2]. It also removes direct usage of exit command with a _exit wrapper. The individual patches have the details. [v1] --> v[2] 1. Added R.B from Darrick in patch 1 of [v1] 2. Kept the init_rc call that was deleted in the v1. 3. Introduced _exit wrapper around exit command. This will help us get correct exit codes ("$?") on failures. [1] https://lore.kernel.org/all/20250206155251.GA21787@frogsfrogsfrogs/ [2] https://lore.kernel.org/all/20250210142322.tptpphdntglsz4eq@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx/ [v1] https://lore.kernel.org/all/cover.1741248214.git.nirjhar.roy.lists@xxxxxxxxx/ Nirjhar Roy (IBM) (5): generic/749: Remove redundant sourcing of common/rc check: Remove redundant _test_mount in check check,common{rc,preamble}: Decouple init_rc() call from sourcing common/rc common/config: Introduce _exit wrapper around exit command common: exit --> _exitWhole series looks fine to me. I've got similar patches in my current check-parallel stack, as well as changing common/config to match the "don't run setup code when sourcing the file" behaviour. Reviewed-by: Dave Chinner <dchinner@xxxxxxxxxx>
Thank you for the review. --NR
-- Nirjhar Roy Linux Kernel Developer IBM, Bangalore
