On Sat, Jul 12, 2025 at 07:42:48PM +0530, Ojaswin Mujoo wrote: > From: "Ritesh Harjani (IBM)" <ritesh.list@xxxxxxxxx> > > This tests uses fio to first create a file with mixed mappings. Then it > does atomic writes using aio dio with parallel jobs to the same file > with mixed mappings. This forces the filesystem allocator to allocate > extents over mixed mapping regions to stress FS block allocators. > > Co-developed-by: Ritesh Harjani (IBM) <ritesh.list@xxxxxxxxx> > Signed-off-by: Ritesh Harjani (IBM) <ritesh.list@xxxxxxxxx> > Signed-off-by: Ojaswin Mujoo <ojaswin@xxxxxxxxxxxxx> > --- This patch looks good to me, just the subject: "generic/1227: Add atomic write test using fio verify on file mixed mappings" generally if we write a new test case, we don't use a temporary case number in commit subject, you can just write as "generic: add atomic write test using ..." Other patches (with new test cases) refer to this. With this change, Reviewed-by: Zorro Lang <zlang@xxxxxxxxxx> > tests/generic/1227 | 123 +++++++++++++++++++++++++++++++++++++++++ > tests/generic/1227.out | 2 + > 2 files changed, 125 insertions(+) > create mode 100755 tests/generic/1227 > create mode 100644 tests/generic/1227.out > > diff --git a/tests/generic/1227 b/tests/generic/1227 > new file mode 100755 > index 00000000..cfdc54ec > --- /dev/null > +++ b/tests/generic/1227 > @@ -0,0 +1,123 @@ > +#! /bin/bash > +# SPDX-License-Identifier: GPL-2.0 > +# Copyright (c) 2025 IBM Corporation. All Rights Reserved. > +# > +# FS QA Test 1227 > +# > +# Validate FS atomic write using fio crc check verifier on mixed mappings > +# of a file. > +# > +. ./common/preamble > +. ./common/atomicwrites > + > +_begin_fstest auto aio rw atomicwrites > + > +_require_scratch_write_atomic_multi_fsblock > +_require_odirect > +_require_aio > + > +_scratch_mkfs >> $seqres.full 2>&1 > +_scratch_mount > + > +touch "$SCRATCH_MNT/f1" > +awu_min_write=$(_get_atomic_write_unit_min "$SCRATCH_MNT/f1") > +awu_max_write=$(_get_atomic_write_unit_max "$SCRATCH_MNT/f1") > +aw_bsize=$(_max "$awu_min_write" "$((awu_max_write/4))") > + > +fsbsize=$(_get_block_size $SCRATCH_MNT) > + > +fio_prep_config=$tmp.prep.fio > +fio_aw_config=$tmp.aw.fio > +fio_verify_config=$tmp.verify.fio > +fio_out=$tmp.fio.out > + > +FIO_LOAD=$(($(nproc) * 2 * LOAD_FACTOR)) > +SIZE=$((128 * 1024 * 1024)) > + > +cat >$fio_prep_config <<EOF > +# prep file to have mixed mappings > +[global] > +ioengine=libaio > +fallocate=none > +filename=$SCRATCH_MNT/test-file > +filesize=$SIZE > +bs=$fsbsize > +direct=1 > +group_reporting=1 > + > +# Create written extents > +[prep_written_blocks] > +ioengine=libaio > +rw=randwrite > +io_size=$((SIZE/3)) > +random_generator=lfsr > + > +# Create unwritten extents > +[prep_unwritten_blocks] > +ioengine=falloc > +rw=randwrite > +io_size=$((SIZE/3)) > +random_generator=lfsr > +EOF > + > +cat >$fio_aw_config <<EOF > +# atomic write to mixed mappings of written/unwritten/holes > +[atomic_write_job] > +ioengine=libaio > +rw=randwrite > +direct=1 > +atomic=1 > +random_generator=lfsr > +group_reporting=1 > + > +filename=$SCRATCH_MNT/test-file > +size=$SIZE > +bs=$aw_bsize > +iodepth=$FIO_LOAD > +numjobs=$FIO_LOAD > + > +verify_state_save=0 > +verify=crc32c > +do_verify=0 > +EOF > + > +cat >$fio_verify_config <<EOF > +# verify atomic writes done by previous job > +[verify_job] > +ioengine=libaio > +rw=randwrite > +random_generator=lfsr > +group_reporting=1 > + > +filename=$SCRATCH_MNT/test-file > +size=$SIZE > +bs=$aw_bsize > +iodepth=$FIO_LOAD > + > +verify_state_save=0 > +verify_only=1 > +verify=crc32c > +verify_fatal=1 > +verify_write_sequence=0 > +EOF > + > +_require_fio $fio_aw_config > +_require_fio $fio_verify_config > + > +cat $fio_prep_config >> $seqres.full > +cat $fio_aw_config >> $seqres.full > +cat $fio_verify_config >> $seqres.full > + > +#prepare file with mixed mappings > +$FIO_PROG $fio_prep_config >> $seqres.full > + > +# do atomic writes without verifying > +$FIO_PROG $fio_aw_config >> $seqres.full > + > +# verify data is not torn > +$FIO_PROG $fio_verify_config >> $seqres.full > + > +# success, all done > +echo Silence is golden > +status=0 > +exit > diff --git a/tests/generic/1227.out b/tests/generic/1227.out > new file mode 100644 > index 00000000..2605d062 > --- /dev/null > +++ b/tests/generic/1227.out > @@ -0,0 +1,2 @@ > +QA output created by 1227 > +Silence is golden > -- > 2.49.0 >
