On Thu, Jul 17, 2025 at 9:59 AM Moon Hee Lee <moonhee.lee.ca@xxxxxxxxx> wrote: Just a quick follow-up to close the loop: > > The current patch addresses ext4_update_inline_data() directly, but the > same condition also leads to a BUG_ON in ext4_create_inline_data() [2], > which the earlier approach intended to prevent as well. I missed that ext4_create_inline_data expects the xattr to be absent at that point, since it's about to create it. The BUG_ON(!is.s.not_found) enforces that expectation. The patch I sent earlier didn’t account for this correctly. Returning an error when the xattr was not found would have broken valid behavior in the create path. Thanks again for resolving this with a simple and correct fix. Per-site handling makes sense here, as each path has different expectations about the xattr state. Best regards, Moonhee
