On Wed, Jun 25, 2025 at 11:51:25PM -0400, Theodore Ts'o wrote: > On Wed, Jun 25, 2025 at 02:20:22PM -0700, Leah Rumancik wrote: > > There is a descrepancy between the fsck flags for ext4 during > > filesystem repair and filesystem checking which causes occasional test > > failures. In particular, _check_generic_filesystems uses -f for force > > checking, but _repair_scratch_fs does not. In some tests, such as > > generic/441, we sometimes exit fsck repair early with the filesystem > > being deemed "clean" but then _check_generic_filesystems finds issues > > during the forced full check. Bringing these flags in sync fixes the > > flakes. > > > > Signed-off-by: Leah Rumancik <leah.rumancik@xxxxxxxxx> > > Reviewed-by: Theodore Ts'o <tytso@xxxxxxx> > > Looks good to me, although I might suggest ammending or just dropping > the comment: > > > # Let's hope fsck -y suffices... > > ... since obviously, for ext[234] it wasn't sufficient. :-) Thanks Ted, I'll remove it when I merge this patch :) Thanks, Zorro > > - Ted >
