On Fri 23-05-25 16:58:20, libaokun@xxxxxxxxxxxxxxx wrote:
> From: Baokun Li <libaokun1@xxxxxxxxxx>
>
> Since nobody has used these EXT4_MB_HINT flags for ages,
> let's remove them.
>
> Signed-off-by: Baokun Li <libaokun1@xxxxxxxxxx>
Looks good. Feel free to add:
Reviewed-by: Jan Kara <jack@xxxxxxx>
Honza
> ---
> fs/ext4/ext4.h | 6 ------
> include/trace/events/ext4.h | 3 ---
> 2 files changed, 9 deletions(-)
>
> diff --git a/fs/ext4/ext4.h b/fs/ext4/ext4.h
> index 16c14dd09df6..f6d01702423d 100644
> --- a/fs/ext4/ext4.h
> +++ b/fs/ext4/ext4.h
> @@ -185,14 +185,8 @@ enum criteria {
>
> /* prefer goal again. length */
> #define EXT4_MB_HINT_MERGE 0x0001
> -/* blocks already reserved */
> -#define EXT4_MB_HINT_RESERVED 0x0002
> -/* metadata is being allocated */
> -#define EXT4_MB_HINT_METADATA 0x0004
> /* first blocks in the file */
> #define EXT4_MB_HINT_FIRST 0x0008
> -/* search for the best chunk */
> -#define EXT4_MB_HINT_BEST 0x0010
> /* data is being allocated */
> #define EXT4_MB_HINT_DATA 0x0020
> /* don't preallocate (for tails) */
> diff --git a/include/trace/events/ext4.h b/include/trace/events/ext4.h
> index 156908641e68..33b204165cc0 100644
> --- a/include/trace/events/ext4.h
> +++ b/include/trace/events/ext4.h
> @@ -23,10 +23,7 @@ struct partial_cluster;
>
> #define show_mballoc_flags(flags) __print_flags(flags, "|", \
> { EXT4_MB_HINT_MERGE, "HINT_MERGE" }, \
> - { EXT4_MB_HINT_RESERVED, "HINT_RESV" }, \
> - { EXT4_MB_HINT_METADATA, "HINT_MDATA" }, \
> { EXT4_MB_HINT_FIRST, "HINT_FIRST" }, \
> - { EXT4_MB_HINT_BEST, "HINT_BEST" }, \
> { EXT4_MB_HINT_DATA, "HINT_DATA" }, \
> { EXT4_MB_HINT_NOPREALLOC, "HINT_NOPREALLOC" }, \
> { EXT4_MB_HINT_GROUP_ALLOC, "HINT_GRP_ALLOC" }, \
> --
> 2.46.1
>
--
Jan Kara <jack@xxxxxxxx>
SUSE Labs, CR
