On 30/04/2025 06:20, Ritesh Harjani (IBM) wrote:
This is still an early preview (RFC v2) of multi-fsblock atomic write. Since the core design of the feature looks ready, wanted to post this for some early feedback. We will break this into more smaller and meaningful patches in later revision. However to simplify the review of the core design changes, this version is limited to just two patches. Individual patches might have more details in the commit msg. Note: This overall needs more careful review (other than the core design) which I will be doing in parallel. However it would be helpful if one can provide any feedback on the core design changes. Specially around ext4_iomap_alloc() changes, ->end_io() changes and a new get block flag EXT4_GET_BLOCKS_QUERY_LEAF_BLOCKS.
I gave this a try and it looks ok, specifically atomic writing mixed mappings.
I'll try to look closer that the implementation details. But I do note that you use blkdev_issue_zeroout() to pre-zero any unwritten range which is being atomically written.