On Tue, May 06, 2025 at 02:19:07PM +0530, Nirjhar Roy (IBM) wrote:
>
> On 4/30/25 18:15, Nirjhar Roy (IBM) wrote:
> > This patch series moves all the exit related functions to a separate file -
> > common/exit. This will remove the dependency to source non-related files to use
> > these exit related functions. Thanks to Dave for suggesting this[1]. The second
> > patch replaces exit with _exit in check file - I missed replacing them in [2].
> >
> > [v2] -> v3
> > Addressed Dave's feedbacks.
> > In patch [1/2]
> > - Removed _die() and die_now() from common/exit
> > - Replaced die_now() with _fatal in common/punch
> > - Removed sourcing of common/exit and common/test_names from common/config
> > and moved them to the beginning of check.
> > - Added sourcing of common/test_names in _begin_fstest() since common/config
> > is no more sourcing common/test_names.
> > - Added a blank line in _begin_fstest() after sourcing common/{exit,test_names}
> > In patch [2/2]
> > - Replaced "_exit 1" with _fatal and "echo <error message>; _exit 1" with
> > _fatal <error message>.
> > - Reverted to "exit \$status" in the trap handler registration in check - just
> > to make it more obvious to the reader that we are capturing $status as the
> > final exit value.
>
> Hi Dave and Zorro,
>
> Any further feedback in this version?
This version is good to me, if there's not more review points from others, I'll merge it.
Reviewed-by: Zorro Lang <zlang@xxxxxxxxxx>
>
> --NR
>
> >
> > [v1] https://lore.kernel.org/all/cover.1745390030.git.nirjhar.roy.lists@xxxxxxxxx/
> > [v2] https://lore.kernel.org/all/cover.1745908976.git.nirjhar.roy.lists@xxxxxxxxx/
> > [1] https://lore.kernel.org/all/Z_UJ7XcpmtkPRhTr@xxxxxxxxxxxxxxxxxxx/
> > [2] https://lore.kernel.org/all/48dacdf636be19ae8bff66cc3852d27e28030613.1744181682.git.nirjhar.roy.lists@xxxxxxxxx/
> >
> >
> > Nirjhar Roy (IBM) (2):
> > common: Move exit related functions to a common/exit
> > check: Replace exit with _fatal and _exit in check
> >
> > check | 54 ++++++++++++++++++-------------------------------
> > common/config | 17 ----------------
> > common/exit | 39 +++++++++++++++++++++++++++++++++++
> > common/preamble | 3 +++
> > common/punch | 39 ++++++++++++++++-------------------
> > common/rc | 28 -------------------------
> > 6 files changed, 79 insertions(+), 101 deletions(-)
> > create mode 100644 common/exit
> >
> > --
> > 2.34.1
> >
> --
> Nirjhar Roy
> Linux Kernel Developer
> IBM, Bangalore
>
>
