Re: [PATCH 17/15] xfs: move buftarg atomic write geometry config to setsize_buftarg

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: "Darrick J. Wong" <djwong@xxxxxxxxxx>
Subject: Re: [PATCH 17/15] xfs: move buftarg atomic write geometry config to setsize_buftarg
From: Christoph Hellwig <hch@xxxxxx>
Date: Fri, 2 May 2025 08:58:41 +0200
Cc: John Garry <john.g.garry@xxxxxxxxxx>, brauner@xxxxxxxxxx, hch@xxxxxx, viro@xxxxxxxxxxxxxxxxxx, jack@xxxxxxx, cem@xxxxxxxxxx, linux-fsdevel@xxxxxxxxxxxxxxx, dchinner@xxxxxxxxxx, linux-xfs@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, ojaswin@xxxxxxxxxxxxx, ritesh.list@xxxxxxxxx, martin.petersen@xxxxxxxxxx, linux-ext4@xxxxxxxxxxxxxxx, linux-block@xxxxxxxxxxxxxxx, catherine.hoang@xxxxxxxxxx, linux-api@xxxxxxxxxxxxxxx
In-reply-to: <20250501195305.GG25675@frogsfrogsfrogs>
References: <20250501165733.1025207-1-john.g.garry@oracle.com> <20250501195305.GG25675@frogsfrogsfrogs>
User-agent: Mutt/1.5.17 (2007-11-01)

On Thu, May 01, 2025 at 12:53:05PM -0700, Darrick J. Wong wrote:
> hch: is this better?  patch 16 can move up, and this can be folded into
> patch 5

Much better.  Although I'd also rename xfs_setsize_buftarg to
xfs_configure_buftarg and xfs_buftarg_config_atomic_writes to
xfs_buftarg_configure_atomic_writes for consistency.

References:
- [PATCH v10 00/15] large atomic writes for xfs
  - From: John Garry
- [PATCH 17/15] xfs: move buftarg atomic write geometry config to setsize_buftarg
  - From: Darrick J. Wong

Prev by Date: Re: [PATCH 16/15] xfs: only call xfs_setsize_buftarg once per buffer target
Next by Date: Re: [PATCH v3 1/1] xfs: Fail remount with noattr2 on a v5 with v4 enabled
Previous by thread: [PATCH 17/15] xfs: move buftarg atomic write geometry config to setsize_buftarg
Index(es):
- Date
- Thread

[Index of Archives] [Reiser Filesystem Development] [Ceph FS] [Kernel Newbies] [Security] [Netfilter] [Bugtraq] [Linux FS] [Yosemite National Park] [MIPS Linux] [ARM Linux] [Linux Security] [Linux RAID] [Samba] [Device Mapper] [Linux Media]