"Nirjhar Roy (IBM)" <nirjhar.roy.lists@xxxxxxxxx> writes:
> Some of the "status=<val>;exit" and "exit <val>" were not
> replaced with _exit <val> and _fatal. Doing it now.
>
Indeed a nice cleanup. The changes in this patch looks good to me.
Please feel free to add:
Reviewed-by: Ritesh Harjani (IBM) <ritesh.list@xxxxxxxxx>
So I guess these couple of series was to cleanup exit routines from
common bash scripts. Do we plan to update the tests/ as well where
we call...
status=X
exit
...or updating tests/ is not needed since we didn't find any wrong usage of
"exit X" routines there?
Either ways - I think we might need to update the README at some point
in time which carries this snip. You might need to add that there are
helper routines like _exit() and _fatal() perhaps for use in common
scripts.
<snip>
To force a non-zero exit status use:
status=1
exit
Note that:
exit 1
won't have the desired effect because of the way the exit trap
works.
-ritesh
