On Wed, Apr 23, 2025 at 10:19:02AM +0200, Christoph Hellwig wrote: > On Wed, Apr 23, 2025 at 07:42:51AM +0200, Christoph Hellwig wrote: > > On Mon, Apr 21, 2025 at 09:42:41AM -0700, Darrick J. Wong wrote: > > > Well it turns out that was a stupid question -- zoned=1 can't be enabled > > > with reflink, which means there's no cow fallback so atomic writes just > > > plain don't work: > > > > Exactly. It is still on my todo list to support it, but there are a > > few higher priority items on it as well, in addition to constant > > interruptions for patch reviews :) > > Actually, for zoned we don't need reflink support - as we always write > out place only the stuffing of multiple remaps into a single transaction > is needed. Still no need to force John to do this work, I can look into > this (probably fairly trivial) work once we have good enough test cases > in xfstests that I can trust them to verify I got things right. <nod> I think we'll need a new fstest to set an error trap on a step midway through a multi-extent ioend completion to make sure that's actually working properly. And probably new write commands for fsx and fsstress to exercise RWF_ATOMIC. (Catherine: please send the accumulated atomic writes fstests) --D