On Mon, Jun 23, 2025 at 11:33:20AM +0200, Fabian Pfitzner wrote:
> Make code more readable and consistent with other functions.
>
> Signed-off-by: Fabian Pfitzner <f.pfitzner@xxxxxxxxxxxxxx>
Reviewed-by: Ido Schimmel <idosch@xxxxxxxxxx>
> ---
> lib/bridge.c | 72 +++++++++++++++++++++++++---------------------------
> 1 file changed, 34 insertions(+), 38 deletions(-)
>
> diff --git a/lib/bridge.c b/lib/bridge.c
> index 480693c9..23a102c4 100644
> --- a/lib/bridge.c
> +++ b/lib/bridge.c
> @@ -49,60 +49,56 @@ void bridge_print_vlan_stats(const struct bridge_vlan_xstats *vstats)
> void bridge_print_mcast_querier_state(const struct rtattr *vtb)
> {
> struct rtattr *bqtb[BRIDGE_QUERIER_MAX + 1];
> + const char *querier_ip;
>
> SPRINT_BUF(other_time);
> + __u64 tval;
I suggest removing the blank line before "other_time"
>
> parse_rtattr_nested(bqtb, BRIDGE_QUERIER_MAX, vtb);
> memset(other_time, 0, sizeof(other_time));
