On Mon, Jun 23, 2025 at 11:33:16AM +0200, Fabian Pfitzner wrote:
> Put mcast querier dumping code into a shared function. This function
> will be called from the bridge utility in a later patch.
>
> Adapt the code such that the vtb parameter is used
> instead of tb[IFLA_BR_MCAST_QUERIER_STATE].
>
> Signed-off-by: Fabian Pfitzner <f.pfitzner@xxxxxxxxxxxxxx>
Reviewed-by: Ido Schimmel <idosch@xxxxxxxxxx>
[...]
> +void bridge_print_mcast_querier_state(const struct rtattr *vtb)
> +{
> + struct rtattr *bqtb[BRIDGE_QUERIER_MAX + 1];
> +
I assume you added the blank line because of checkpatch, but I think
it's wrong in this case.
> + SPRINT_BUF(other_time);
> +
> + parse_rtattr_nested(bqtb, BRIDGE_QUERIER_MAX, vtb);
> + memset(other_time, 0, sizeof(other_time));
