On 6/23/25 10:45, Fabian Pfitzner wrote: > On 6/20/25 14:44, Nikolay Aleksandrov wrote: >> On 6/20/25 15:16, Fabian Pfitzner wrote: >>> Dump the multicast querier state per vlan. >>> This commit is almost identical to [1]. >>> >>> The querier state can be seen with: >>> >>> bridge -d vlan global >>> >>> The options for vlan filtering and vlan mcast snooping have to be enabled >>> in order to see the output: >>> >>> ip link set [dev] type bridge mcast_vlan_snooping 1 vlan_filtering 1 >>> >>> The querier state shows the following information for IPv4 and IPv6 >>> respectively: >>> >>> 1) The ip address of the current querier in the network. This could be >>> ourselves or an external querier. >>> 2) The port on which the querier was seen >>> 3) Querier timeout in seconds >>> >>> [1] https://git.kernel.org/pub/scm/network/iproute2/iproute2.git/commit/?id=16aa4494d7fc6543e5e92beb2ce01648b79f8fa2 >>> >>> Signed-off-by: Fabian Pfitzner <f.pfitzner@xxxxxxxxxxxxxx> >>> --- >>> >>> v1->v2 >>> - refactor code >>> - link to v1: https://lore.kernel.org/netdev/20250604105322.1185872-1-f.pfitzner@xxxxxxxxxxxxxx/ >>> >>> v2->v3 >>> - move code into a shared function >>> - use shared function in bridge and ip utility >>> - link to v2: https://lore.kernel.org/netdev/20250611121151.1660231-1-f.pfitzner@xxxxxxxxxxxxxx/ >>> --- >>> bridge/vlan.c | 3 +++ >>> include/bridge.h | 3 +++ >>> ip/iplink_bridge.c | 57 +--------------------------------------------- >>> lib/bridge.c | 56 +++++++++++++++++++++++++++++++++++++++++++++ >>> 4 files changed, 63 insertions(+), 56 deletions(-) >>> >> Hi, >> The subject should contain the target for this patch which is iproute2-next, >> e.g. [PATCH iproute2-next v3]. Since there would be another version, I'd split >> it in 2 patches - 1 that moves the existing code to lib/bridge.c and the second >> which adds the vlan querier print code. >> >> Also a few comments below.. > I'll split it into three commits then: > 1. Move existing code into shared function > 2. Call shared function in bridge/vlan.c as well > 3. Refactor code according to Ido's code proposal from v1 Sounds good to me. Thanks!
