Re: [PATCH iproute2-next v2 4/4] ip: iplink_bridge: Support bridge VLAN stats in `ip stats'

[Nikolay Aleksandrov <razor@xxxxxxxxxxxxx>]

On 6/9/25 19:05, Petr Machata wrote:
> Add support for displaying bridge VLAN statistics in `ip stats'.
> Reuse the existing `bridge vlan' display and JSON format:
>
>   # ip stats show dev v2 group xstats_slave subgroup bridge suite vlan
>   2: v2: group xstats_slave subgroup bridge suite vlan
>                     10
>                       RX: 3376 bytes 50 packets
>                       TX: 2824 bytes 44 packets
>
>                     20
>                       RX: 684 bytes 7 packets
>                       TX: 0 bytes 0 packets
>
>   # ip -j -p stats show dev v2 group xstats_slave subgroup bridge suite vlan
>   [ {
>           "ifindex": 2,
>           "ifname": "v2",
>           "group": "xstats_slave",
>           "subgroup": "bridge",
>           "suite": "vlan",
>           "vlans": [ {
>                   "vid": 10,
>                   "rx_bytes": 3376,
>                   "rx_packets": 50,
>                   "tx_bytes": 2824,
>                   "tx_packets": 44
>               },{
>                   "vid": 20,
>                   "rx_bytes": 684,
>                   "rx_packets": 7,
>                   "tx_bytes": 0,
>                   "tx_packets": 0
>               } ]
>       } ]
>
> Similarly for the master stats:
>
>   # ip stats show dev br1 group xstats subgroup bridge suite vlan
>   211: br1: group xstats subgroup bridge suite vlan
>                     10
>                       RX: 3376 bytes 50 packets
>                       TX: 2824 bytes 44 packets
>
>                     20
>                       RX: 684 bytes 7 packets
>                       TX: 0 bytes 0 packets
>
>   # ip -j -p stats show dev br1 group xstats subgroup bridge suite vlan
>   [ {
>           "ifindex": 211,
>           "ifname": "br1",
>           "group": "xstats",
>           "subgroup": "bridge",
>           "suite": "vlan",
>           "vlans": [ {
>                   "vid": 10,
>                   "flags": [ ],
>                   "rx_bytes": 3376,
>                   "rx_packets": 50,
>                   "tx_bytes": 2824,
>                   "tx_packets": 44
>               },{
>                   "vid": 20,
>                   "flags": [ ],
>                   "rx_bytes": 684,
>                   "rx_packets": 7,
>                   "tx_bytes": 0,
>                   "tx_packets": 0
>               } ]
>       } ]
>
> Signed-off-by: Petr Machata <petrm@xxxxxxxxxx>
> ---
>
> Notes:
>      v2:
>      - Add the master stats as well.
>
>   ip/iplink_bridge.c | 48 ++++++++++++++++++++++++++++++++++++++++++++++
>   1 file changed, 48 insertions(+)

Acked-by: Nikolay Aleksandrov <razor@xxxxxxxxxxxxx>