Re: [PATCH v3 3/3] kselftest/arm64: Add lsfe to the hwcaps test

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Sep 16, 2025 at 10:16:11PM +0100, Will Deacon wrote:
> On Mon, Aug 18, 2025 at 08:21:20PM +0100, Mark Brown wrote:

> > +	/* LDFADD H0, H0, [X0] */
> > +	asm volatile(".inst 0x7c200000"
> > +		     : "+r" (memp)

> Doesn't this corrupt H0 without the compiler knowing? It's probably
> easier to use STFADD.

Yeah, that's more correct and easier than specifying constraints.  In
practice it should be safe as the compiler is unlikely to use FP in the
instructions it generates and it's a caller saved register.  The program
is in general not careful with constraints.

> > +		     :
> > +		     : "cc", "memory");

> Why do you need the "cc" clobber?

It's overkill.

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Linux FS]     [Yosemite Forum]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Device Mapper]     [Linux Resources]

  Powered by Linux