> +struct mucse_hw_operations {
> + int (*reset_hw)(struct mucse_hw *hw);
> + void (*driver_status)(struct mucse_hw *hw, bool enable, int mode);
> +};
Again, there is only one instance of this. Will there be more?
> + * rnpgbe_get_permanent_mac - Get permanent mac
> + * @hw: hw information structure
> + * @mac_addr: pointer to store mac
> + *
> + * rnpgbe_get_permanent_mac tries to get mac from hw.
> + * It use eth_random_addr if failed.
> + **/
> +static void rnpgbe_get_permanent_mac(struct mucse_hw *hw,
> + u8 *mac_addr)
> +{
> + struct device *dev = &hw->pdev->dev;
> +
> + if (mucse_fw_get_macaddr(hw, hw->pfvfnum, mac_addr, hw->lane) ||
> + !is_valid_ether_addr(mac_addr)) {
> + dev_warn(dev, "Failed to get valid MAC from FW, using random\n");
> + eth_random_addr(mac_addr);
> + }
With a function named rnpgbe_get_permanent_mac(), i would not expect
it to return a random MAC address. If there is no permanent MAC
address, return -EINVAL, and let the caller does with the error.
> +static int rnpgbe_reset_hw_ops(struct mucse_hw *hw)
> +{
> + struct mucse_dma_info *dma = &hw->dma;
> + int err;
> +
> + dma_wr32(dma, RNPGBE_DMA_AXI_EN, 0);
> + err = mucse_mbx_fw_reset_phy(hw);
> + if (err)
> + return err;
> + /* Store the permanent mac address */
> + if (!(hw->flags & M_FLAGS_INIT_MAC_ADDRESS))
What do this hw->flags add to the driver? Why is it here?
> static void rnpgbe_rm_adapter(struct pci_dev *pdev)
> {
> struct mucse *mucse = pci_get_drvdata(pdev);
> + struct mucse_hw *hw = &mucse->hw;
> struct net_device *netdev;
>
> if (!mucse)
> return;
> netdev = mucse->netdev;
> + if (netdev->reg_state == NETREG_REGISTERED)
> + unregister_netdev(netdev);
Is that possible?
> mucse->netdev = NULL;
> + hw->ops->driver_status(hw, false, mucse_driver_insmod);
> free_netdev(netdev);
> }
>
> --
> 2.25.1
>
