On Fri, Aug 22, 2025 at 05:33:43PM -0700, Jay Vosburgh wrote:
> Hangbin Liu <liuhangbin@xxxxxxxxx> wrote:
>
> >Introduce a new netlink attribute 'ad_actor_port_prio' to allow setting
>
> Nit here "actor_port_prio"?
>
> One more comment below ...
>
> >the LACP actor port priority on a per-slave basis. This extends the
> >existing bonding infrastructure to support more granular control over
> >LACP negotiations.
> >
> >The priority value is embedded in LACPDU packets and will be used by
> >subsequent patches to influence aggregator selection policies.
> >
> >Signed-off-by: Hangbin Liu <liuhangbin@xxxxxxxxx>
> >---
> > Documentation/networking/bonding.rst | 9 +++++++
> > drivers/net/bonding/bond_3ad.c | 4 ++++
> > drivers/net/bonding/bond_netlink.c | 16 +++++++++++++
> > drivers/net/bonding/bond_options.c | 36 ++++++++++++++++++++++++++++
> > include/net/bond_3ad.h | 1 +
> > include/net/bond_options.h | 1 +
> > include/uapi/linux/if_link.h | 1 +
> > 7 files changed, 68 insertions(+)
> >
...
> >diff --git a/drivers/net/bonding/bond_3ad.c b/drivers/net/bonding/bond_3ad.c
> >index 2fca8e84ab10..eb0fb7374391 100644
> >+static const struct bond_opt_value bond_actor_port_prio_tbl[] = {
> >+ { "minval", 1, BOND_VALFLAG_MIN},
> >+ { "maxval", 65535, BOND_VALFLAG_MAX},
> >+ { "default", 255, BOND_VALFLAG_DEFAULT},
> >+ { NULL, -1, 0},
>
> Does the standard forbid actor_port_prio being set to zero? The
> description I'm finding says only that it's an unsigned integer and two
> octets in size (802.1AX-2014 6.4.2.3 LACPDU structure).
>
> -J
Yes, I also can't find a clear doc about the minimal value of port priority.
I will set it to 0.
Thanks
Hangbin
