On Wed, Aug 27, 2025 at 9:45 AM Alex Tran <alex.t.tran@xxxxxxxxx> wrote: > changelog: > v2 I think Jonathan will trim these two lines when applying... > Replace FIXME comments in the pinctrl documentation example with > proper cleanup code: > - Add devm_pinctrl_put() calls in error paths > (pinctrl_lookup_state, pinctrl_select_state) > after successful devm_pinctrl_get() > - Set foo->p to NULL when devm_pinctrl_get() fails > - Add ret variable for cleaner error handling > - provides proper example of pinctrl resource management on failure > > Signed-off-by: Alex Tran <alex.t.tran@xxxxxxxxx> ... but it looks good otherwise! Reviewed-by: Linus Walleij <linus.walleij@xxxxxxxxxx> Yours, Linus Walleij