On Tue, Aug 26, 2025 at 04:20:54PM -0700, Randy Dunlap wrote: > > + > > +/** > > + * map_range() - Install translation for an IOVA range > > Maybe I don't understand the macros (haven't looked lately). > > Function name appears to be map_pages(), not map_range(). There is a later series that changes this around and it didn't get split up right > > + * @iommu_table: Table to operate on > > + * @top_paddr: New CPU physical address of the top pointer > > + * @top_level: IOMMU PT level of the new top > > We don't really have a way to document parameters of a callback function > inside a struct, but for now kernel-doc.py won't complain about it. > (Somehow kernel-doc.pl did once upon a time and then that became dead code.) Seems like we should :) Fixed the rest, thanks Jason
