Hi Marcelo, kernel test robot noticed the following build errors: [auto build test ERROR on 91812d3843409c235f336f32f1c37ddc790f1e03] url: https://github.com/intel-lab-lkp/linux/commits/Marcelo-Schmitt/iio-adc-ad4030-Fix-_scale-for-when-oversampling-is-enabled/20250830-084901 base: 91812d3843409c235f336f32f1c37ddc790f1e03 patch link: https://lore.kernel.org/r/0d9f377295635d977e0767de9db96d0a6ad06de0.1756511030.git.marcelo.schmitt%40analog.com patch subject: [PATCH 07/15] iio: adc: ad4030: Add SPI offload support config: x86_64-buildonly-randconfig-005-20250830 (https://download.01.org/0day-ci/archive/20250830/202508301919.3TZbcu20-lkp@xxxxxxxxx/config) compiler: gcc-12 (Debian 12.2.0-14+deb12u1) 12.2.0 reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250830/202508301919.3TZbcu20-lkp@xxxxxxxxx/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp@xxxxxxxxx> | Closes: https://lore.kernel.org/oe-kbuild-all/202508301919.3TZbcu20-lkp@xxxxxxxxx/ All errors (new ones prefixed by >>): drivers/iio/adc/ad4030.c: In function '__ad4030_set_sampling_freq': >> drivers/iio/adc/ad4030.c:518:23: error: implicit declaration of function 'pwm_round_waveform_might_sleep' [-Werror=implicit-function-declaration] 518 | ret = pwm_round_waveform_might_sleep(st->conv_trigger, &conv_wf); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ drivers/iio/adc/ad4030.c: In function 'ad4030_offload_buffer_postenable': >> drivers/iio/adc/ad4030.c:1055:15: error: implicit declaration of function 'pwm_set_waveform_might_sleep' [-Werror=implicit-function-declaration] 1055 | ret = pwm_set_waveform_might_sleep(st->conv_trigger, &st->conv_wf, false); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~ cc1: some warnings being treated as errors vim +/pwm_round_waveform_might_sleep +518 drivers/iio/adc/ad4030.c 496 497 static int __ad4030_set_sampling_freq(struct ad4030_state *st, unsigned int freq) 498 { 499 struct spi_offload_trigger_config *config = &st->offload_trigger_config; 500 struct pwm_waveform conv_wf = { }; 501 u64 offload_period_ns; 502 u64 offload_offset_ns; 503 u32 mode; 504 int ret; 505 u64 target = AD4030_TCNVH_NS; 506 507 conv_wf.period_length_ns = DIV_ROUND_CLOSEST(NSEC_PER_SEC, freq); 508 /* 509 * The datasheet lists a minimum time of 9.8 ns, but no maximum. If the 510 * rounded PWM's value is less than 10, increase the target value by 10 511 * and attempt to round the waveform again, until the value is at least 512 * 10 ns. Use a separate variable to represent the target in case the 513 * rounding is severe enough to keep putting the first few results under 514 * the minimum 10ns condition checked by the while loop. 515 */ 516 do { 517 conv_wf.duty_length_ns = target; > 518 ret = pwm_round_waveform_might_sleep(st->conv_trigger, &conv_wf); 519 if (ret) 520 return ret; 521 target += 10; 522 } while (conv_wf.duty_length_ns < 10); 523 524 offload_period_ns = conv_wf.period_length_ns; 525 526 ret = regmap_read(st->regmap, AD4030_REG_MODES, &mode); 527 if (ret) 528 return ret; 529 if (FIELD_GET(AD4030_REG_MODES_MASK_OUT_DATA_MODE, mode) == AD4030_OUT_DATA_MD_30_AVERAGED_DIFF) { 530 u32 avg; 531 532 ret = regmap_read(st->regmap, AD4030_REG_AVG, &avg); 533 if (ret) 534 return ret; 535 536 offload_period_ns <<= FIELD_GET(AD4030_REG_AVG_MASK_AVG_VAL, avg); 537 } 538 539 config->periodic.frequency_hz = DIV_ROUND_UP_ULL(NSEC_PER_SEC, 540 offload_period_ns); 541 542 /* 543 * The hardware does the capture on zone 2 (when spi trigger PWM 544 * is used). This means that the spi trigger signal should happen at 545 * tsync + tquiet_con_delay being tsync the conversion signal period 546 * and tquiet_con_delay 9.8ns. Hence set the PWM phase accordingly. 547 * 548 * The PWM waveform API only supports nanosecond resolution right now, 549 * so round this setting to the closest available value. 550 */ 551 offload_offset_ns = AD4030_TQUIET_CNV_DELAY_NS; 552 do { 553 config->periodic.offset_ns = offload_offset_ns; 554 ret = spi_offload_trigger_validate(st->offload_trigger, config); 555 if (ret) 556 return ret; 557 offload_offset_ns += 10; 558 559 } while (config->periodic.offset_ns < AD4030_TQUIET_CNV_DELAY_NS); 560 561 st->conv_wf = conv_wf; 562 563 return 0; 564 } 565 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki
