út 12. 8. 2025 v 19:22 odesílatel Ivan Pravdin <ipravdin.official@xxxxxxxxx> napsal: > > When running rtla as > > `rtla <timerlat|osnoise> <top|hist> -t custom_file.txt -a 100` > > -a options override trace output filename specified by -t option. > Running the command above will create <timerlat|osnoise>_trace.txt file > instead of custom_file.txt. Fix this by making sure that -a option does > not override trace output filename even if it's passed after trace > output filename is specified. > Yes, this should not be overridden, it's a bug in both the old implementation and the new one using actions. Thank you for the fix. > Remove clear_terminal in timerlat top as it removes "Saving trace to <filename>" > line from the terminal and is not used in other modes. > This is not the correct fix for the issue. clear_terminal is needed in timerlat top (and osnoise top) to clear the terminal before the updated status is printed, the fix removes it without a replacement, breaking this behavior. Also, this is a different issue that appeared only when the actions patchset [1] was merged, and should go into a separate patch with a different Fixes tag. [1] https://lore.kernel.org/linux-trace-kernel/20250626123405.1496931-1-tglozar@xxxxxxxxxx/T/#t Tomas
