On Tue, 2 Sep 2025 16:29:33 +0200 Matthieu Baerts wrote: > On 01/09/2025 11:39, Matthieu Baerts (NGI0) wrote: > > This series contains 4 independent new features: > > > > - Patch 1: use HMAC-SHA256 library instead of open-coded HMAC. > > > > - Patches 2-3: make ADD_ADDR retransmission timeout adaptive + simplify > > selftests. > > I just noticed that NIPA reported some issues due to these 2 patches. In > short, some packets (MPTCP ADD_ADDR notifications) can now be > retransmitted quicker, but some tests check MIB counters and don't > expect retransmissions. If the environment is a bit slow, it is possible > to have more retransmissions. We should adapt the tests to avoid false > positives. > > Is it possible to drop just these two patches? Or do you prefer to mark > the whole series as "Changes requested"? Your call, we can also apply as is. mptcp-join is ignored, anyway.
