Re: [PATCH net-next v03 05/14] hinic3: Command Queue flush interfaces

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Fan Gong <gongfan1@xxxxxxxxxx>
Subject: Re: [PATCH net-next v03 05/14] hinic3: Command Queue flush interfaces
From: Jakub Kicinski <kuba@xxxxxxxxxx>
Date: Tue, 2 Sep 2025 18:15:42 -0700
Cc: Zhu Yikai <zhuyikai1@xxxxxxxxxxxxxx>, <netdev@xxxxxxxxxxxxxxx>, <linux-kernel@xxxxxxxxxxxxxxx>, "David S. Miller" <davem@xxxxxxxxxxxxx>, Eric Dumazet <edumazet@xxxxxxxxxx>, Paolo Abeni <pabeni@xxxxxxxxxx>, Simon Horman <horms@xxxxxxxxxx>, Andrew Lunn <andrew+netdev@xxxxxxx>, <linux-doc@xxxxxxxxxxxxxxx>, Jonathan Corbet <corbet@xxxxxxx>, Bjorn Helgaas <helgaas@xxxxxxxxxx>, luosifu <luosifu@xxxxxxxxxx>, Xin Guo <guoxin09@xxxxxxxxxx>, Shen Chenyang <shenchenyang1@xxxxxxxxxxxxx>, Zhou Shuai <zhoushuai28@xxxxxxxxxx>, Wu Like <wulike1@xxxxxxxxxx>, Shi Jing <shijing34@xxxxxxxxxx>, Meny Yossefi <meny.yossefi@xxxxxxxxxx>, Gur Stavi <gur.stavi@xxxxxxxxxx>, Lee Trager <lee@xxxxxxxxx>, Michael Ellerman <mpe@xxxxxxxxxxxxxx>, Vadim Fedorenko <vadim.fedorenko@xxxxxxxxx>, Suman Ghosh <sumang@xxxxxxxxxxx>, Przemek Kitszel <przemyslaw.kitszel@xxxxxxxxx>, Joe Damato <jdamato@xxxxxxxxxx>, Christophe JAILLET <christophe.jaillet@xxxxxxxxxx>
In-reply-to: <a82cf0c769d351a3245343bc1b1de93927d694c6.1756524443.git.zhuyikai1@h-partners.com>
References: <cover.1756524443.git.zhuyikai1@h-partners.com> <a82cf0c769d351a3245343bc1b1de93927d694c6.1756524443.git.zhuyikai1@h-partners.com>

On Sat, 30 Aug 2025 16:08:44 +0800 Fan Gong wrote:
> +	/* wait for chip to stop I/O */
> +	msleep(100);

This is a bit questionable. Is there no way to find out if the
transactions for a given queues are still in flight?

References:
- [PATCH net-next v03 00/14] net: hinic3: Add a driver for Huawei 3rd gen NIC - sw and hw initialization
  - From: Fan Gong
- [PATCH net-next v03 05/14] hinic3: Command Queue flush interfaces
  - From: Fan Gong

Prev by Date: Re: [PATCH net-next v03 02/14] hinic3: HW management interfaces
Next by Date: Re: [PATCH net-next v03 12/14] hinic3: Add port management
Previous by thread: [PATCH net-next v03 05/14] hinic3: Command Queue flush interfaces
Next by thread: [PATCH net-next v03 12/14] hinic3: Add port management
Index(es):
- Date
- Thread

[Index of Archives] [Kernel Newbies] [Security] [Netfilter] [Bugtraq] [Linux FS] [Yosemite Forum] [MIPS Linux] [ARM Linux] [Linux Security] [Linux RAID] [Samba] [Video 4 Linux] [Device Mapper] [Linux Resources]