Re: [PATCH v17 28/33] fs/resctrl: Introduce mbm_L3_assignments to list assignments in a group

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Babu,

On 8/14/25 7:25 PM, Babu Moger wrote:
> diff --git a/Documentation/filesystems/resctrl.rst b/Documentation/filesystems/resctrl.rst
> index 1de815b3a07b..af0c38206bab 100644
> --- a/Documentation/filesystems/resctrl.rst
> +++ b/Documentation/filesystems/resctrl.rst
> @@ -519,6 +519,34 @@ When the "mba_MBps" mount option is used all CTRL_MON groups will also contain:
>  	/sys/fs/resctrl/info/L3_MON/mon_features changes the input
>  	event.
>  
> +"mbm_L3_assignments":

Looking at the final documentation this addition is made in unexpected section titled:
"When the "mba_MBps" mount option is used all CTRL_MON groups will also contain:"

How about placing this description in a new section titled "When monitoring is enabled all
MON groups may also contain:" (note the word *may*) under the "mon_hw_id" description to complement
the earlier "When monitoring is enabled all MON groups will also contain:" (note the
word *will*). Open to other ideas of course.

Actual change looks good to me, just the doc placement is unexpected.

Reinette




[Index of Archives]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Linux FS]     [Yosemite Forum]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Device Mapper]     [Linux Resources]

  Powered by Linux