Re: [PATCH net-next] bonding: Remove support for use_carrier

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 9/3/25 12:50, Nikolay Aleksandrov wrote:
On 9/2/25 19:11, Stanislav Fomichev wrote:
On 08/29, Jay Vosburgh wrote:
[snip]
      return 0;

Acked-by: Stanislav Fomichev <sdf@xxxxxxxxxxx>

nit: any reason not to return -EINVAL here when the new value is not "1"?
You do it for the module param, but not for the sysfs file here.


bond options code already returns EINVAL for values not described in the option's value
table, after Jay removed "0" from there it should automatically cause -EINVAL to be returned



Still fixing email problems, I see now that this is an old thread.
Please ignore my reply, sorry for the noise!

Cheers,
 Nik




[Index of Archives]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Linux FS]     [Yosemite Forum]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Device Mapper]     [Linux Resources]

  Powered by Linux