On Wed, Sep 03, 2025 at 01:43:02PM +0100, Vadim Fedorenko wrote: > On 03/09/2025 12:12, Yibo Dong wrote: > > On Wed, Sep 03, 2025 at 11:53:17AM +0100, Vadim Fedorenko wrote: > > > On 03/09/2025 03:54, Dong Yibo wrote: > > > > Initialize basic mbx function. > > > > > > > > Signed-off-by: Dong Yibo <dong100@xxxxxxxxx> > > > > --- > > > > drivers/net/ethernet/mucse/rnpgbe/Makefile | 3 +- > > > > drivers/net/ethernet/mucse/rnpgbe/rnpgbe.h | 16 + > > > > .../net/ethernet/mucse/rnpgbe/rnpgbe_chip.c | 3 + > > > > .../net/ethernet/mucse/rnpgbe/rnpgbe_mbx.c | 393 ++++++++++++++++++ > > > > .../net/ethernet/mucse/rnpgbe/rnpgbe_mbx.h | 25 ++ > > > > 5 files changed, 439 insertions(+), 1 deletion(-) > > > > create mode 100644 drivers/net/ethernet/mucse/rnpgbe/rnpgbe_mbx.c > > > > create mode 100644 drivers/net/ethernet/mucse/rnpgbe/rnpgbe_mbx.h > > > > > > > > diff --git a/drivers/net/ethernet/mucse/rnpgbe/rnpgbe_chip.c b/drivers/net/ethernet/mucse/rnpgbe/rnpgbe_chip.c > > > > index 179621ea09f3..f38daef752a3 100644 > > > > --- a/drivers/net/ethernet/mucse/rnpgbe/rnpgbe_chip.c > > > > +++ b/drivers/net/ethernet/mucse/rnpgbe/rnpgbe_chip.c > > > > @@ -1,8 +1,11 @@ > > > > // SPDX-License-Identifier: GPL-2.0 > > > > /* Copyright(c) 2020 - 2025 Mucse Corporation. */ > > > > +#include <linux/string.h> > > > > > > I don't see a reason to have string.h included into rnpgbe_chip.c > > > > > > > You are right, I should add it when it is used. > > > > > > + > > > > #include "rnpgbe.h" > > > > #include "rnpgbe_hw.h" > > > > +#include "rnpgbe_mbx.h" > > > > > > I believe this part has to be done in the previous patch. > > > Please, be sure that the code can compile after every patch in the > > > patchset. > > > > > > > You mean 'include "rnpgbe_mbx.h"'? But 'rnpgbe_mbx.h' is added in this patch. > > Ok, so what's in rnpgbe_chip.c which needs rnpgbe_mbx.h to be included? > If the change is introduced later in patch 5, the move this include to > it as well. > You are right, I will move it to patch 5. > > I had compiled every patch before submission for this series. And as you > > remind, I will keep check this in the future. > > > > Thanks for your feedback. > > > > Thanks for your feedback.
