Hi, Robin > > This adds a new dynamic PMU to the Perf Events framework to program and > > control the Uncore PCI PMUs in Fujitsu chips. > > > > This driver was created with reference to drivers/perf/qcom_l3_pmu.c. > > > > This driver exports formatting and event information to sysfs so it can > > be used by the perf user space tools with the syntaxes: > > > > perf stat -e pci_iod0_pci0/ea-pci/ ls > > perf stat -e pci_iod0_pci0/event=0x80/ ls > > > > FUJITSU-MONAKA PMU Events Specification v1.1 URL: > > https://github.com/fujitsu/FUJITSU-MONAKA > > > > Signed-off-by: Koichi Okuno <fj2767dz@xxxxxxxxxxx> > > --- > > .../admin-guide/perf/fujitsu_pci_pmu.rst | 50 ++ > > Documentation/admin-guide/perf/index.rst | 1 + > > drivers/perf/Kconfig | 9 + > > drivers/perf/Makefile | 1 + > > drivers/perf/fujitsu_pci_pmu.c | 536 ++++++++++++++++++ > > From a quick side-by-side skim, this is a copy-paste of the exact same > driver from patch #1 with s/mac/pci/g applied. Please don't do that. If > the hardware is functionally the same, then it should just be a single > driver that can then pick which PMU name and set of event alias > attributes to use for a given instance based on the ACPI HID match > (and/or any other ID register info you may have.) I've integrated the MAC PMU driver and the PCI PMU driver into a single driver in v8. Best Regards, Koichi Okuno
