Hi, So I'm not quite sure why I'm CC'ed, nor do I really care much, but since I was idly reading through it anyway ... > + if (unlikely(offset < -134217728 || offset > 134217724)) { > + WARN_ON_ONCE(true); > + } Seems like that should just be WARN_ON_ONCE(offset < -134217728 || offset > 134217724); since the unlikely is in there already. > + if (early_boot_irqs_disabled) { > + copy_to_kernel_nofault(addr, &insn, sizeof(insn)); > + } else { > + patch_insn_write(addr, insn); > + } (and maybe that doesn't need braces) johannes