On 9/8/2025 1:02 AM, Vadim Fedorenko wrote:
> > int hinic3_init_hwdev(struct pci_dev *pdev)
> > {
> > struct hinic3_pcidev *pci_adapter = pci_get_drvdata(pdev);
> > @@ -451,6 +463,7 @@ int hinic3_init_hwdev(struct pci_dev *pdev)
> > hwdev->pdev = pci_adapter->pdev;
> > hwdev->dev = &pci_adapter->pdev->dev;
> > hwdev->func_state = 0;
> > + hwdev->dev_id = hinic3_adev_idx_alloc();
>
> Why do you need dev_id? It's not used anywhere in the patchset. The
> commit doesn't explain it neither...
Thanks for your commit.
This is the code to refine the first patchset of hinic3 driver. In
hinic3_lld.c, we use "hadev->adev.id = hwdev->dev_id;" and dev_id
is temporarily set to default value 0. In this patchset we complete
hwdev's initialization.
I will update this commit message to explain this modification.
