On 08/09/2025 16:38, Mark Brown wrote: > On Fri, Sep 05, 2025 at 08:40:25PM +0100, Usama Arif wrote: > >> diff --git a/tools/testing/selftests/mm/prctl_thp_disable.c b/tools/testing/selftests/mm/prctl_thp_disable.c >> index 89ed0d7db1c16..0afcdbad94f3d 100644 >> --- a/tools/testing/selftests/mm/prctl_thp_disable.c >> +++ b/tools/testing/selftests/mm/prctl_thp_disable.c >> @@ -9,6 +9,7 @@ >> #include <string.h> >> #include <unistd.h> >> #include <sys/mman.h> >> +#include <linux/mman.h> >> #include <sys/prctl.h> >> #include <sys/wait.h> > >> should fix this issue? > > That seems to do the right thing for me, I'm slightly nervous about > collisions with glibc in future (it's been an issue in the past when > they're not using our headers) but I guess we can deal with that if it > actually comes up. I have seen this included in another selftest as well with MADV_COLLAPSE. I think best to have it. I will send a patch with it. Thanks for confirming!
