On 9/8/25 12:02 PM, David Hildenbrand wrote:
On 08.09.25 20:56, Anthony Yznaga wrote:
On 9/8/25 11:45 AM, David Hildenbrand wrote:
On 20.08.25 03:03, Anthony Yznaga wrote:
From: Khalid Aziz <khalid@xxxxxxxxxx>
An mshare region contains zero or more actual vmas that map objects
in the mshare range with shared page tables.
Signed-off-by: Khalid Aziz <khalid@xxxxxxxxxx>
Signed-off-by: Matthew Wilcox (Oracle) <willy@xxxxxxxxxxxxx>
Signed-off-by: Anthony Yznaga <anthony.yznaga@xxxxxxxxxx>
---
Why can't we query the mapping instead?
The bit check is nice and zippy since vma_is_mshare() is called for
every fault, but it's not required. The check could be made to be:
return vma->vm_ops == &msharefs_vm_ops;
Yes, like we do in secretmem_mapping(), for example.
(there, we also have a vma_is_secretmem()).
Okay, I'll make that change. Thanks!
