"Matthieu Baerts (NGI0)" <matttbe@xxxxxxxxxx> writes: > This attribute is used as a signed number in the code in pm_netlink.c: > > nla_put_s32(skb, MPTCP_ATTR_IF_IDX, ssk->sk_bound_dev_if)) > > The specs should then reflect that. Note that other 'if-idx' attributes > from the same .yaml file use a signed number as well. Note that mptcp_pm_parse_entry has this, which should maybe be fixed at the same time: u32 val = nla_get_s32(tb[MPTCP_PM_ADDR_ATTR_IF_IDX]); https://elixir.bootlin.com/linux/v6.16.5/source/net/mptcp/pm_netlink.c#L116 > > Fixes: bc8aeb2045e2 ("Documentation: netlink: add a YAML spec for mptcp") > Cc: stable@xxxxxxxxxxxxxxx > Reviewed-by: Geliang Tang <geliang@xxxxxxxxxx> > Signed-off-by: Matthieu Baerts (NGI0) <matttbe@xxxxxxxxxx> > --- > Documentation/netlink/specs/mptcp_pm.yaml | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Documentation/netlink/specs/mptcp_pm.yaml b/Documentation/netlink/specs/mptcp_pm.yaml > index 02f1ddcfbf1cfd81a398dd03c52bb9f281c1aa08..d15335684ec3d6256505f2b3887ce5818eb57462 100644 > --- a/Documentation/netlink/specs/mptcp_pm.yaml > +++ b/Documentation/netlink/specs/mptcp_pm.yaml > @@ -256,7 +256,7 @@ attribute-sets: > type: u32 > - > name: if-idx > - type: u32 > + type: s32 > - > name: reset-reason > type: u32
