On Tue, Sep 09, 2025 at 01:55:54PM -0700, Jakub Kicinski wrote:
> On Tue, 9 Sep 2025 19:52:21 +0530 Anwar, Md Danish wrote:
> > > + for (i = 0; i < size_in_words; i++)
> > > + msg[i] = mbx_data_rd32(mbx, MUCSE_MBX_FWPF_SHM + 4 * i);
> >
> > The array indexing calculation should use multiplication by sizeof(u32)
> > instead of hardcoded 4.
>
> Not sure this is really necessary, I'd expect C programmers to intuit
> that 4 is the number of bytes in u32 here. sizeof(u32) is going to
> overflow 80 char line limit and cause more harm than good.
>
I found similar code in other drivers, ixgbe, it like this:
#define IXGBE_READ_REG_ARRAY(a, reg, offset) \
ixgbe_read_reg((a), (reg) + ((offset) << 2))
for (i = 0; i < size; i++)
msg[i] = IXGBE_READ_REG_ARRAY(hw, IXGBE_PFMBMEM(vf_number), i);
Maybe I should follow that style?
Thanks for your feedback.
