On Thu, Aug 14, 2025 at 05:40:14PM +0530, MD Danish Anwar wrote: > On 14/08/25 1:08 pm, Dong Yibo wrote: > > Initialize basic mbx_fw ops, such as get_capability, reset phy > > and so on. > > > > Signed-off-by: Dong Yibo <dong100@xxxxxxxxx> > > --- > > drivers/net/ethernet/mucse/rnpgbe/Makefile | 3 +- > > drivers/net/ethernet/mucse/rnpgbe/rnpgbe.h | 4 + > > .../net/ethernet/mucse/rnpgbe/rnpgbe_mbx_fw.c | 264 ++++++++++++++++++ > > .../net/ethernet/mucse/rnpgbe/rnpgbe_mbx_fw.h | 201 +++++++++++++ > > 4 files changed, 471 insertions(+), 1 deletion(-) > > create mode 100644 drivers/net/ethernet/mucse/rnpgbe/rnpgbe_mbx_fw.c > > create mode 100644 drivers/net/ethernet/mucse/rnpgbe/rnpgbe_mbx_fw.h > > > > > + > > +/** > > + * mbx_cookie_zalloc - Alloc a cookie structure > > + * @priv_len: private length for this cookie > > + * > > + * @return: cookie structure on success > > + **/ > > +static struct mbx_req_cookie *mbx_cookie_zalloc(int priv_len) > > +{ > > + struct mbx_req_cookie *cookie; > > + > > + cookie = kzalloc(struct_size(cookie, priv, priv_len), GFP_KERNEL); > > + if (cookie) { > > + cookie->timeout_jiffes = 30 * HZ; > > Typo: should be "timeout_jiffies" instead of "timeout_jiffes" > Got it, I will fix it. > > + cookie->magic = COOKIE_MAGIC; > > + cookie->priv_len = priv_len; > > + } > > + return cookie; > > +} > > + > > +/** > > > -- > Thanks and Regards, > Danish > > Thanks for you feedback.