On Mon, 11 Aug 2025 at 10:32, James Clark <james.clark@xxxxxxxxxx> wrote:
>
> Fix holes and convert the long list of bools to single bits to save
> some space because there's one of these for each ETM.
>
> Signed-off-by: James Clark <james.clark@xxxxxxxxxx>
> ---
> drivers/hwtracing/coresight/coresight-etm4x.h | 39 ++++++++++++++-------------
> 1 file changed, 20 insertions(+), 19 deletions(-)
>
> diff --git a/drivers/hwtracing/coresight/coresight-etm4x.h b/drivers/hwtracing/coresight/coresight-etm4x.h
> index a355a1e9606d..1c67b263b01b 100644
> --- a/drivers/hwtracing/coresight/coresight-etm4x.h
> +++ b/drivers/hwtracing/coresight/coresight-etm4x.h
> @@ -1020,29 +1020,30 @@ struct etmv4_drvdata {
> u8 ns_ex_level;
> u8 q_support;
> u8 os_lock_model;
> - bool sticky_enable;
> - bool boot_enable;
> - bool os_unlock;
> - bool instrp0;
> - bool q_filt;
> - bool trcbb;
> - bool trccond;
> - bool retstack;
> - bool trccci;
> - bool trc_error;
> - bool syncpr;
> - bool stallctl;
> - bool sysstall;
> - bool nooverflow;
> - bool atbtrig;
> - bool lpoverride;
> + bool sticky_enable : 1;
> + bool boot_enable : 1;
> + bool os_unlock : 1;
> + bool instrp0 : 1;
> + bool q_filt : 1;
> + bool trcbb : 1;
> + bool trccond : 1;
> + bool retstack : 1;
> + bool trccci : 1;
> + bool trc_error : 1;
> + bool syncpr : 1;
> + bool stallctl : 1;
> + bool sysstall : 1;
> + bool nooverflow : 1;
> + bool atbtrig : 1;
> + bool lpoverride : 1;
> + bool state_needs_restore : 1;
> + bool skip_power_up : 1;
> + bool paused : 1;
> u64 trfcr;
> struct etmv4_config config;
> u64 save_trfcr;
> struct etmv4_save_state *save_state;
> - bool state_needs_restore;
> - bool skip_power_up;
> - bool paused;
> +
> DECLARE_BITMAP(arch_features, ETM4_IMPDEF_FEATURE_MAX);
> };
>
>
> --
> 2.34.1
>
Reviewed-by: Mike Leach <mike.leach@xxxxxxxxxx>
--
Mike Leach
Principal Engineer, ARM Ltd.
Manchester Design Centre. UK
