Re: [PATCH v5 12/14] RDMA/ionic: Register device ops for miscellaneous functionality

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 





On 14/08/2025 8:38, Abhijit Gangurde wrote:
@@ -50,6 +251,17 @@ static const struct ib_device_ops ionic_dev_ops = {
  	.poll_cq = ionic_poll_cq,
  	.req_notify_cq = ionic_req_notify_cq,
+ .query_device = ionic_query_device,
+	.query_port = ionic_query_port,
+	.get_link_layer = ionic_get_link_layer,
+	.query_pkey = ionic_query_pkey,
+	.modify_device = ionic_modify_device,
+	.get_port_immutable = ionic_get_port_immutable,
+	.get_dev_fw_str = ionic_get_dev_fw_str,
+	.get_vector_affinity = ionic_get_vector_affinity,

I see there is no usage of get_vector_affinity(). It is called from
ib_get_vector_affinity() and no one is calling ib_get_vector_affinity().

So, in case you re-spin the series, can you drop it?

Thanks
Shay

+	.device_group = &ionic_rdma_attr_group,
+	.disassociate_ucontext = ionic_disassociate_ucontext,
+
  	INIT_RDMA_OBJ_SIZE(ib_ucontext, ionic_ctx, ibctx),
  	INIT_RDMA_OBJ_SIZE(ib_pd, ionic_pd, ibpd),
  	INIT_RDMA_OBJ_SIZE(ib_ah, ionic_ah, ibah),





[Index of Archives]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Linux FS]     [Yosemite Forum]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Device Mapper]     [Linux Resources]

  Powered by Linux