Re: [PATCH 01/13] docs: Move the "features" tools to tools/doc

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Em Wed, 13 Aug 2025 16:42:42 -0700
Randy Dunlap <rdunlap@xxxxxxxxxxxxx> escreveu:

> On 8/13/25 4:38 PM, Mauro Carvalho Chehab wrote:
> > Em Wed, 13 Aug 2025 15:32:00 -0600
> > Jonathan Corbet <corbet@xxxxxxx> escreveu:
> >   
> >> The scripts for managing the features docs are found in three different
> >> directories; unite them all under tools/doc and update references as
> >> needed.
> >>
> >> Signed-off-by: Jonathan Corbet <corbet@xxxxxxx>
> >> ---
> >>  Documentation/sphinx/kernel_feat.py                           | 4 ++--
> >>  .../features/scripts => tools/doc}/features-refresh.sh        | 0
> >>  {scripts => tools/doc}/get_feat.pl                            | 2 +-  
> > 
> > This one is the next on my list to convert to Python, but I didn't
> > do any changes on it yet.  
> 
> Just curious, why does it need to be converted from shell to Python?
> I'm sure you will explain that in the patch description (or cover letter).

The rationale is the same as kernel-doc and get-abi: there is a Sphinx
extension that executes it. By converting it into Python and splitting
the code into an exec and a library, we can use the library directly at
the extension.

Besides that, the code in Python, specially after using modules and 
classes, become IMO clearer, making easier to maintain, specially if
we avoid functions inside functions, complex class inheritance, lamba
functions and multiple statements on a single line.

Thanks,
Mauro




[Index of Archives]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Linux FS]     [Yosemite Forum]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Device Mapper]     [Linux Resources]

  Powered by Linux