On 8/12/2025 3:09 PM, Dong Yibo wrote: > Initialize n500/n210 chip bar resource map and > dma, eth, mbx ... info for future use. > > Signed-off-by: Dong Yibo <dong100@xxxxxxxxx> > --- > drivers/net/ethernet/mucse/rnpgbe/Makefile | 3 +- > drivers/net/ethernet/mucse/rnpgbe/rnpgbe.h | 60 +++++++++ > .../net/ethernet/mucse/rnpgbe/rnpgbe_chip.c | 88 ++++++++++++++ > drivers/net/ethernet/mucse/rnpgbe/rnpgbe_hw.h | 12 ++ > .../net/ethernet/mucse/rnpgbe/rnpgbe_main.c | 115 ++++++++++++++++++ > 5 files changed, 277 insertions(+), 1 deletion(-) > create mode 100644 drivers/net/ethernet/mucse/rnpgbe/rnpgbe_chip.c > create mode 100644 drivers/net/ethernet/mucse/rnpgbe/rnpgbe_hw.h > > diff --git a/drivers/net/ethernet/mucse/rnpgbe/Makefile b/drivers/net/ethernet/mucse/rnpgbe/Makefile > index 9df536f0d04c..42c359f459d9 100644 > --- a/drivers/net/ethernet/mucse/rnpgbe/Makefile > +++ b/drivers/net/ethernet/mucse/rnpgbe/Makefile > @@ -5,4 +5,5 @@ > # > > obj-$(CONFIG_MGBE) += rnpgbe.o > -rnpgbe-objs := rnpgbe_main.o > +rnpgbe-objs := rnpgbe_main.o\ > + rnpgbe_chip.o > diff --git a/drivers/net/ethernet/mucse/rnpgbe/rnpgbe.h b/drivers/net/ethernet/mucse/rnpgbe/rnpgbe.h > index 23c84454e7c7..0dd3d3cb2a4d 100644 > --- a/drivers/net/ethernet/mucse/rnpgbe/rnpgbe.h > +++ b/drivers/net/ethernet/mucse/rnpgbe/rnpgbe.h > @@ -4,18 +4,78 @@ > #ifndef _RNPGBE_H > #define _RNPGBE_H > > +#include <linux/types.h> > + > +extern const struct rnpgbe_info rnpgbe_n500_info; > +extern const struct rnpgbe_info rnpgbe_n210_info; > +extern const struct rnpgbe_info rnpgbe_n210L_info; > + > enum rnpgbe_boards { > board_n500, > board_n210, > board_n210L, > }; > > +enum rnpgbe_hw_type { > + rnpgbe_hw_n500 = 0, > + rnpgbe_hw_n210, > + rnpgbe_hw_n210L, > + rnpgbe_hw_unknow > +}; The enum value name should be "rnpgbe_hw_unknown" not "rnpgbe_hw_unknow" (missing 'n'). > + > +struct mucse_dma_info { > + void __iomem *dma_base_addr; > + void __iomem *dma_ring_addr; > + void *back; > + u32 dma_version; > +}; > + > +struct mucse_eth_info { > + void __iomem *eth_base_addr; > + void *back; > +}; > + > +struct mucse_mac_info { > + void __iomem *mac_addr; > + void *back; > +}; > + > +struct mucse_mbx_info { > + /* fw <--> pf mbx */ > + u32 fw_pf_shm_base; > + u32 pf2fw_mbox_ctrl; > + u32 pf2fw_mbox_mask; > + u32 fw_pf_mbox_mask; > + u32 fw2pf_mbox_vec; > +}; > + > +struct mucse_hw { > + void *back; > + void __iomem *hw_addr; > + void __iomem *ring_msix_base; > + struct pci_dev *pdev; > + enum rnpgbe_hw_type hw_type; > + struct mucse_dma_info dma; > + struct mucse_eth_info eth; > + struct mucse_mac_info mac; > + struct mucse_mbx_info mbx; > + u32 driver_version; > + u16 usecstocount; > +}; > + > struct mucse { > struct net_device *netdev; > struct pci_dev *pdev; > + struct mucse_hw hw; > u16 bd_number; > }; > > +struct rnpgbe_info { > + int total_queue_pair_cnts; > + enum rnpgbe_hw_type hw_type; > + void (*init)(struct mucse_hw *hw); > +}; > + > /* Device IDs */ > #define PCI_VENDOR_ID_MUCSE 0x8848 > #define PCI_DEVICE_ID_N500_QUAD_PORT 0x8308 > diff --git a/drivers/net/ethernet/mucse/rnpgbe/rnpgbe_chip.c b/drivers/net/ethernet/mucse/rnpgbe/rnpgbe_chip.c > new file mode 100644 > index 000000000000..20ec67c9391e > --- /dev/null > +++ b/drivers/net/ethernet/mucse/rnpgbe/rnpgbe_chip.c > @@ -0,0 +1,88 @@ > +// SPDX-License-Identifier: GPL-2.0 > +/* Copyright(c) 2020 - 2025 Mucse Corporation. */ > + > +#include "rnpgbe.h" > +#include "rnpgbe_hw.h" > + > +/** > + * rnpgbe_init_common - Setup common attribute > + * @hw: hw information structure > + **/ > +static void rnpgbe_init_common(struct mucse_hw *hw) > +{ > + struct mucse_dma_info *dma = &hw->dma; > + struct mucse_eth_info *eth = &hw->eth; > + struct mucse_mac_info *mac = &hw->mac; > + > + dma->dma_base_addr = hw->hw_addr; > + dma->dma_ring_addr = hw->hw_addr + RNPGBE_RING_BASE; > + dma->back = hw; > + > + eth->eth_base_addr = hw->hw_addr + RNPGBE_ETH_BASE; > + eth->back = hw; > + > + mac->mac_addr = hw->hw_addr + RNPGBE_MAC_BASE; > + mac->back = hw; > +} > + > +/** > + * rnpgbe_init_n500 - Setup n500 hw info > + * @hw: hw information structure > + * > + * rnpgbe_init_n500 initializes all private > + * structure, such as dma, eth, mac and mbx base on > + * hw->addr for n500 > + **/ > +static void rnpgbe_init_n500(struct mucse_hw *hw) > +{ > + struct mucse_mbx_info *mbx = &hw->mbx; > + > + rnpgbe_init_common(hw); > + > + mbx->fw2pf_mbox_vec = 0x28b00; > + mbx->fw_pf_shm_base = 0x2d000; > + mbx->pf2fw_mbox_ctrl = 0x2e000; > + mbx->fw_pf_mbox_mask = 0x2e200; > + hw->ring_msix_base = hw->hw_addr + 0x28700; > + hw->usecstocount = 125; > +} > + > +/** > + * rnpgbe_init_n210 - Setup n210 hw info > + * @hw: hw information structure > + * > + * rnpgbe_init_n210 initializes all private > + * structure, such as dma, eth, mac and mbx base on > + * hw->addr for n210 > + **/ > +static void rnpgbe_init_n210(struct mucse_hw *hw) > +{ > + struct mucse_mbx_info *mbx = &hw->mbx; > + > + rnpgbe_init_common(hw); > + > + mbx->fw2pf_mbox_vec = 0x29400; > + mbx->fw_pf_shm_base = 0x2d900; > + mbx->pf2fw_mbox_ctrl = 0x2e900; > + mbx->fw_pf_mbox_mask = 0x2eb00; > + hw->ring_msix_base = hw->hw_addr + 0x29000; > + hw->usecstocount = 62; > +} I don't see pf2fw_mbox_mask getting initialized anywhere. Is that not needed? > + > +const struct rnpgbe_info rnpgbe_n500_info = { -- Thanks and Regards, Md Danish Anwar