Hi Babu,
On 8/5/25 4:30 PM, Babu Moger wrote:
> parse_cbm() and parse_bw() require mode and CLOSID to validate the Capacity
Again [1], parse_bw() does not validate any CBMs.
To be more specific: "mode" -> "resource group mode"?
> Bit Mask (CBM). It is passed via struct rdtgroup in struct rdt_parse_data.
>
> The io_alloc feature also uses CBMs to indicate which portions of cache are
> allocated for I/O traffic. The CBMs are provided by user space and need to
> be validated the same as CBMs provided for general (CPU) cache allocation.
> parse_cbm() cannot be used as-is since io_alloc does not have rdtgroup
> context.
>
> Pass the mode and CLOSID directly to parse_cbm() via struct rdt_parse_data
> instead of through the rdtgroup struct to facilitate calling parse_cbm() to
> verify the CBM of the io_alloc feature.
>
> Signed-off-by: Babu Moger <babu.moger@xxxxxxx>
> ---
...
> @@ -156,9 +157,10 @@ static bool cbm_validate(char *buf, u32 *data, struct rdt_resource *r)
> static int parse_cbm(struct rdt_parse_data *data, struct resctrl_schema *s,
> struct rdt_ctrl_domain *d)
> {
> - struct rdtgroup *rdtgrp = data->rdtgrp;
> + enum rdtgrp_mode mode = data->mode;
> struct resctrl_staged_config *cfg;
> struct rdt_resource *r = s->res;
> + u32 closid = data->closid;
> u32 cbm_val;
>
> cfg = &d->staged_config[s->conf_type];
> @@ -171,7 +173,7 @@ static int parse_cbm(struct rdt_parse_data *data, struct resctrl_schema *s,
> * Cannot set up more than one pseudo-locked region in a cache
> * hierarchy.
> */
> - if (rdtgrp->mode == RDT_MODE_PSEUDO_LOCKSETUP &&
> + if (mode == RDT_MODE_PSEUDO_LOCKSETUP &&
> rdtgroup_pseudo_locked_in_hierarchy(d)) {
> rdt_last_cmd_puts("Pseudo-locked region in hierarchy\n");
> return -EINVAL;
> @@ -180,8 +182,8 @@ static int parse_cbm(struct rdt_parse_data *data, struct resctrl_schema *s,
> if (!cbm_validate(data->buf, &cbm_val, r))
> return -EINVAL;
>
> - if ((rdtgrp->mode == RDT_MODE_EXCLUSIVE ||
> - rdtgrp->mode == RDT_MODE_SHAREABLE) &&
> + if ((mode == RDT_MODE_EXCLUSIVE ||
> + mode == RDT_MODE_SHAREABLE) &&
This can now be on one line?
> rdtgroup_cbm_overlaps_pseudo_locked(d, cbm_val)) {
> rdt_last_cmd_puts("CBM overlaps with pseudo-locked region\n");
> return -EINVAL;
Reinette
[1] https://lore.kernel.org/lkml/798ba4db-3ac2-44a9-9e0d-e9cbb0dbff45@xxxxxxxxx/
