Hi Babu,
On 8/6/25 2:02 PM, Moger, Babu wrote:
> On 7/25/25 13:29, Babu Moger wrote:
>> diff --git a/fs/resctrl/rdtgroup.c b/fs/resctrl/rdtgroup.c
>> index ca0475b75390..c7ca9113a12a 100644
>> --- a/fs/resctrl/rdtgroup.c
>> +++ b/fs/resctrl/rdtgroup.c
>> @@ -1799,6 +1799,36 @@ static ssize_t mbm_local_bytes_config_write(struct kernfs_open_file *of,
>> return ret ?: nbytes;
>> }
>>
>> +static int resctrl_mbm_assign_mode_show(struct kernfs_open_file *of,
>> + struct seq_file *s, void *v)
>> +{
>> + struct rdt_resource *r = rdt_kn_parent_priv(of->kn);
>> + bool enabled;
>> +
>> + mutex_lock(&rdtgroup_mutex);
>> + enabled = resctrl_arch_mbm_cntr_assign_enabled(r);
>> +
>> + if (r->mon.mbm_cntr_assignable) {
>> + if (enabled)
>> + seq_puts(s, "[mbm_event]\n");
>> + else
>> + seq_puts(s, "[default]\n");
>> +
>> + if (!IS_ENABLED(CONFIG_RESCTRL_ASSIGN_FIXED)) {
>> + if (enabled)
>> + seq_puts(s, "default\n");
>> + else
>> + seq_puts(s, "mbm_event\n");
>> + }
>> + } else {
>> + seq_puts(s, "[default]\n");
>> + }
>> +
>> + mutex_unlock(&rdtgroup_mutex);
>> +
>> + return 0;
>> +}
>
> The resctrl_mbm_assign_mode_show() can also be moved to monitor.c.
>
> What do you think?
I agree. monitor.c is appropriate for this code.
Reinette
