On Thu, 31 Jul 2025 at 05:30, Cryolitia PukNgae <liziyao@xxxxxxxxxxxxx> wrote: > > Personally, I'd prefer to maintain this small driver in the hwmon > subsystem until we need to write drivers for the same EC with more > diverse subsystem functionality. We can then discuss and learn how to > evolve it. I personally don't think that's going to happen in the near > future. > > So, could we continue reviewing the current patch series? Where are we > stuck? Either is fine by me. The move is simply a rename anyway. My reasoning was it will take a bit of back and forth to get approved and charge limiting is a standard feature now on all manufacturers except GPD, so I expect them to add it soon. But since it is a rename, it is not a blocker for reviewing in any case. If you want more comments I think you should send a new current version so it can be reviewed again. It has been a while since the previous one. Antheas > 在 2025/7/31 01:26, Guenter Roeck 写道: > > On 7/30/25 02:24, Cryolitia wrote: > >> Thank you for raising this valid concern. We've closely monitored GPD's > >> development plans and currently see no indication of EC functionality > >> expansion beyond thermal sensors in the foreseeable future. Given this > >> observation, we believe placing the driver in hwmon remains appropriate > >> for now. > >> > >> That said, we fully respect your maintainer perspective on > >> future-proofing. If you feel strongly that platform/x86 would be a safer > >> long-term home despite the current scope, we're happy to move the driver > >> there immediately. We're committed to finding the most sustainable > >> solution for upstream. > >> > > > > As hwmon maintainer, I feel strongly (since you used the word) that moving > > the driver (or any hwmon driver, for that matter) out of hwmon space would > > be a bad idea, but I won't prevent you from doing it either. It means less > > work for me, after all. > > > > Guenter > > > > > >
