Hi Babu, On 7/25/25 11:29 AM, Babu Moger wrote: > The "mbm_event" counter assignment mode allows the user to assign a > hardware counter to an RMID, event pair and monitor the bandwidth as long > as it is assigned. The user can specify the memory transaction(s) for the > counter to track. > > Add the definitions for supported memory transactions (e.g., read, write, > etc.) the counter can be configured with. > > Signed-off-by: Babu Moger <babu.moger@xxxxxxx> > --- ... > --- > fs/resctrl/internal.h | 11 +++++++++++ > fs/resctrl/monitor.c | 11 +++++++++++ > include/linux/resctrl_types.h | 3 +++ > 3 files changed, 25 insertions(+) > > diff --git a/fs/resctrl/internal.h b/fs/resctrl/internal.h > index eeee83a5067a..693268bcbad2 100644 > --- a/fs/resctrl/internal.h > +++ b/fs/resctrl/internal.h Looks like only monitoring code in monitor.c needs to know about struct mbm_transaction so this can stay within monitor.c ? > @@ -216,6 +216,17 @@ struct rdtgroup { > struct pseudo_lock_region *plr; > }; > > +/** > + * struct mbm_transaction - Memory transaction an MBM event can be configured with. > + * @name: Name of memory transaction (read, write ...). > + * @val: The bit (eg. READS_TO_LOCAL_MEM or READS_TO_REMOTE_MEM) used to > + * represent the memory transaction within an event's configuration. > + */ > +struct mbm_transaction { > + char name[32]; > + u32 val; > +}; > + > /* rdtgroup.flags */ > #define RDT_DELETED 1 > Reinette